Change in vdsm[master]: Introduction for caching the parsed domain XML

nsoffer at redhat.com nsoffer at redhat.com
Mon Mar 24 12:53:43 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: Introduction for caching the parsed domain XML
......................................................................


Patch Set 13:

(1 comment)

http://gerrit.ovirt.org/#/c/17694/13/vdsm/vm.py
File vdsm/vm.py:

Line 5108:     def _getUnderlyingDisplayPort(self):
Line 5109:         """
Line 5110:         Obtain display port info from libvirt.
Line 5111:         """
Line 5112:         graphics = self._lastXMLDesc.firstElementByTagName('graphics')
> Well and before it was an out of index error in that case. Not sure how rel
Right, so this can wait for another patch.
Line 5113:         port = graphics.getAttribute('port')
Line 5114:         if port:
Line 5115:             self.conf['displayPort'] = port
Line 5116:         port = graphics.getAttribute('tlsPort')


-- 
To view, visit http://gerrit.ovirt.org/17694
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list