Change in vdsm[master]: sp: fix spm start when failing to produce domain

ewarszaw at redhat.com ewarszaw at redhat.com
Sun Mar 23 15:10:26 UTC 2014


Eduardo has posted comments on this change.

Change subject: sp: fix spm start when failing to produce domain
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 207:                 if domain.getDomainRole() == sd.REGULAR_DOMAIN:
Line 208:                     continue
Line 209: 
Line 210:                 self._backend.setDomainRegularRole(domain)
Line 211:             except Exception:
> As Sergey wrote, it was introduced in I2ecf801d58b34c1c811e311e3779887a406a
Use your git-fu and look in 3.0!
Line 212:                 # log any exception, but keep going
Line 213:                 self.log.error("Error trying to check/update domain %s role",
Line 214:                                sdUUID, exc_info=True)
Line 215: 


Line 209: 
Line 210:                 self._backend.setDomainRegularRole(domain)
Line 211:             except Exception:
Line 212:                 # log any exception, but keep going
Line 213:                 self.log.error("Error trying to check/update domain %s role",
> Eduardo, this is behavior change that is debatable (and we can discuss it r
Your are killing any sense of the SPM semantics and you can understand it if you were so kind to read other people comments, in this patch and in the BZ.

As stated in the BZ you have  nothing to do with monitor domains, use getStorageDomainsList() in order to discover reachable domains.
(Supported on all versions.)

Your "requeriments" and "behavioral changes" are the result of careless changes in the engine reconstruct flows.
Line 214:                                sdUUID, exc_info=True)
Line 215: 
Line 216:     @unsecured
Line 217:     def startSpm(self, prevID, prevLVER, maxHostID, expectedDomVersion=None):


-- 
To view, visit http://gerrit.ovirt.org/25424
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4f34360770ca8c8741a50956d0cab92bcd9a810
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list