Change in vdsm[master]: sp: fix spm start when failing to produce domain

laravot at redhat.com laravot at redhat.com
Sun Mar 23 14:42:38 UTC 2014


Liron Ar has posted comments on this change.

Change subject: sp: fix spm start when failing to produce domain
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 207:                 if domain.getDomainRole() == sd.REGULAR_DOMAIN:
Line 208:                     continue
Line 209: 
Line 210:                 self._backend.setDomainRegularRole(domain)
Line 211:             except Exception:
> Nothing here: http://gerrit.ovirt.org/#/q/I593060e354c0bdc9b19f4e11a376094d
As sergey wrote, seems like it was introduced in  I2ecf801d58b34c1c811e311e3779887a406af5f0.
Line 212:                 # log any exception, but keep going
Line 213:                 self.log.error("Error trying to check/update domain %s role",
Line 214:                                sdUUID, exc_info=True)
Line 215: 


Line 207:                 if domain.getDomainRole() == sd.REGULAR_DOMAIN:
Line 208:                     continue
Line 209: 
Line 210:                 self._backend.setDomainRegularRole(domain)
Line 211:             except Exception:
> You are wrong.
As Sergey wrote, it was introduced in I2ecf801d58b34c1c811e311e3779887a406af5f0.
Line 212:                 # log any exception, but keep going
Line 213:                 self.log.error("Error trying to check/update domain %s role",
Line 214:                                sdUUID, exc_info=True)
Line 215: 


Line 209: 
Line 210:                 self._backend.setDomainRegularRole(domain)
Line 211:             except Exception:
Line 212:                 # log any exception, but keep going
Line 213:                 self.log.error("Error trying to check/update domain %s role",
> SPM _should not_ start or continue in the same if it is not capable to reac
Eduardo, this is behavior change that is debatable (and we can discuss it regardless) and isn't related to this bug - this bug is about the changed requirements for succesful start spm introduced in  I2ecf801d58b34c1c811e311e3779887a406af5f0, not a change the terms for succesfully starting the spm and related side effacts from it.

Just to add - ReconstructMaster won't help you in all vdsm versions, because if you reconstruct without this domain appearing as "active"/without this domain listed you won't have domain monitoring for this domain so you won't be able to tell when it's reachable (and not all versions support "monitordomains").

To sum it up, the spmStart "requirments" were changed in patch  I2ecf801d58b34c1c811e311e3779887a406af5f0 since last december and should be fixed, discussions about other refactors can be done regardless.
Line 214:                                sdUUID, exc_info=True)
Line 215: 
Line 216:     @unsecured
Line 217:     def startSpm(self, prevID, prevLVER, maxHostID, expectedDomVersion=None):


-- 
To view, visit http://gerrit.ovirt.org/25424
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4f34360770ca8c8741a50956d0cab92bcd9a810
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list