Change in vdsm[master]: setupNetworks: Fix incorrect mtu overriding when adding mult...

danken at redhat.com danken at redhat.com
Fri Mar 21 13:35:24 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: setupNetworks: Fix incorrect mtu overriding when adding multiple networks
......................................................................


setupNetworks: Fix incorrect mtu overriding when adding multiple networks

When configuring several networks over a bond, if the iteration over
the networks to be added made networks with lower MTUs to be added
after those with higher ones, the last mtu, regardless of value would
be set.

This was because the _netinfo object is passed from addNetworks to
addNetworks and the objectivize of the succeeding addNetworks would
not see the higher MTUs set by the preceding addNetworks. This would
only affect the bond MTU when some bond setting would be detected
as changed and it would trigger bond reconfiguring (for a list of
what is checked for changes, see netmodels.py:Bond.configure).

Change-Id: Ia375c2e0e4a1896ab99d734e3203a5ef49570f36
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072411
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/25343
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/functional/networkTests.py
M vdsm/configNetwork.py
2 files changed, 39 insertions(+), 1 deletion(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/25343
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia375c2e0e4a1896ab99d734e3203a5ef49570f36
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list