Change in vdsm[master]: setupNetworks: Fix incorrect mtu overriding when adding mult...

danken at redhat.com danken at redhat.com
Thu Mar 20 12:05:20 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: setupNetworks: Fix incorrect mtu overriding when adding multiple networks
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/25343/2/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 253:                 '%s found unexpectedly in running config' % vlanName)
Line 254: 
Line 255:     def assertMtu(self, mtu, *elems):
Line 256:         for elem in elems:
Line 257:             self.assertEquals(int(mtu), int(self.vdsm_net.getMtu(elem)))
> vdsm returns always a non-int MTU for backwards compatibility reasons. The 
darn.
Line 258: 
Line 259:     @cleanupNet
Line 260:     @permutations([[True], [False]])
Line 261:     @RequireDummyMod


-- 
To view, visit http://gerrit.ovirt.org/25343
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia375c2e0e4a1896ab99d734e3203a5ef49570f36
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list