Change in vdsm[master]: vdsm: Add ACPI support for VM shutdown/reboot

danken at redhat.com danken at redhat.com
Thu Mar 20 01:05:33 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Add ACPI support for VM shutdown/reboot
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/23457/6/vdsm/vmCommands.py
File vdsm/vmCommands.py:

Line 1: #
I still find it hard to swallow the concept of  command pattern. Please limit this module to vmpowerdown.py (notice the all-lowercase name), and not too generic vmCommands.
Line 2: # Copyright 2008-2013 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by


-- 
To view, visit http://gerrit.ovirt.org/23457
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc4f4140913df9827cca296e880b37f47a21b76
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list