Change in vdsm[master]: vdsm: Add ACPI support for VM shutdown/reboot

asegurap at redhat.com asegurap at redhat.com
Wed Mar 19 22:24:09 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: vdsm: Add ACPI support for VM shutdown/reboot
......................................................................


Patch Set 6: Code-Review-1

(3 comments)

Some minor nits and a problem. The problem is that just as you added the new module to vdsm.spec.in it should be added to debian/vdsm.install as well.

http://gerrit.ovirt.org/#/c/23457/6/vdsm/vmCommands.py
File vdsm/vmCommands.py:

Line 1: #
Line 2: # Copyright 2008-2013 Red Hat, Inc.
Wouldn't this be 2014? This is mostly new code, afaict
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


Line 55:         if utils.tobool(vm.conf.get('acpiEnable', 'true')):
Line 56:             self.chain.addCallback(self.acpiCallback)
Line 57: 
Line 58:     def start(self):
Line 59:         # are there any available methods for shutdown/reboot?
I'd say this comment should refer to "Are there any available methods for power down?" otherwise it is referring to subclasses which is not that nice.
Line 60:         if self.chain.callbacks:
Line 61:             # flag for successful power-down event detection
Line 62:             # this flag is common for both shutdown and reboot workflows
Line 63:             # because we want to exit the CallbackChain in case either


Line 71:             # No tools, no ACPI
Line 72:             return {
Line 73:                 'status': {
Line 74:                     'code': errCode['exist']['status']['code'],
Line 75:                     'message': 'VM without ACPI or active SolidICE tools. '
Shouldn't this be "oVirt guest agent" instead of "SolidICE tools"?
Line 76:                                'Try Forced Shutdown.'}}
Line 77: 
Line 78: 
Line 79: class VmShutdown(VmPowerDown):


-- 
To view, visit http://gerrit.ovirt.org/23457
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc4f4140913df9827cca296e880b37f47a21b76
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list