Change in vdsm[master]: cleanup: make VmDevice.custom ever-present

danken at redhat.com danken at redhat.com
Fri Mar 7 21:51:33 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: cleanup: make VmDevice.custom ever-present
......................................................................


cleanup: make VmDevice.custom ever-present

Device configuration may carry a "custom properties" dictionary that is
copied into its respective VmDevice object. If no such dictionary exist,
the VmDevice.custom is never set.

This patch removes this duality. VmDevice.custom is always there, but it
may be empty if the user has not set any device-specific custom
property.

Change-Id: Icf0677b3d52c3e51c874dcb2b4df12fb3fc22c34
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/25391
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
---
M vdsm/vm.py
1 file changed, 14 insertions(+), 17 deletions(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/25391
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icf0677b3d52c3e51c874dcb2b4df12fb3fc22c34
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list