Change in vdsm[master]: pep8: whitelist everything

danken at redhat.com danken at redhat.com
Wed Mar 5 10:45:16 UTC 2014


Dan Kenigsberg has uploaded a new change for review.

Change subject: pep8: whitelist everything
......................................................................

pep8: whitelist everything

.. except for four auto-generated *.py files

Change-Id: I237e19d5cdd087d8fe0f337f41560b72b1c80a37
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
---
M Makefile.am
M lib/vdsm/tool/dummybr.py
2 files changed, 3 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/25392/1

diff --git a/Makefile.am b/Makefile.am
index 9b1a3c9..3f4266c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -53,27 +53,7 @@
 WITH_HOOKS = --define="with_hooks 1"
 endif
 
-# When fixing a file to conform with pep8 add it to the WL here so it will be
-# checkd from now on
-PEP8_WHITELIST = \
-	client \
-	lib/vdsm/*.py \
-	lib/vdsm/*.py.in \
-	tests \
-	vds_bootstrap \
-	vdsm-tool \
-	vdsm/*.py \
-	vdsm/*.py.in \
-	vdsm/netconf \
-	vdsm/sos/vdsm.py.in \
-	vdsm/storage \
-	vdsm/vdsm \
-	vdsm_api \
-	vdsm_hooks \
-	vdsm_reg \
-	$(NULL)
-
-PEP8_BLACKLIST = config.py,constants.py
+PEP8_BLACKLIST = config.py,constants.py,crossImportsTests.py,vdsm.py
 
 SKIP_PYFLAKES_ERR = "\./vdsm/storage/lvm\.py.*: list comprehension redefines \
 	'lv' from line .*"
@@ -84,8 +64,7 @@
 		grep -w -v $(SKIP_PYFLAKES_ERR) | \
 		while read LINE; do echo "$$LINE"; false; done
 	$(PEP8) --version
-	$(PEP8) --exclude="$(PEP8_BLACKLIST)" --filename '*.py,*.py.in' \
-		$(PEP8_WHITELIST)
+	$(PEP8) --exclude="$(PEP8_BLACKLIST)" --filename '*.py,*.py.in' .
 	@if test -f .gitignore; then \
 	  for i in `git ls-files \*.in`; do \
 	    if ! grep -q -x $${i%%.in} .gitignore; then \
diff --git a/lib/vdsm/tool/dummybr.py b/lib/vdsm/tool/dummybr.py
index be4a1da..d5825f2 100644
--- a/lib/vdsm/tool/dummybr.py
+++ b/lib/vdsm/tool/dummybr.py
@@ -40,6 +40,7 @@
             '''<network><name>%s</name><forward mode='bridge'/><bridge '''
             '''name='%s'/></network>''' % (bridgeName, bridgeName))
 
+
 @expose('dummybr')
 def main():
     """


-- 
To view, visit http://gerrit.ovirt.org/25392
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I237e19d5cdd087d8fe0f337f41560b72b1c80a37
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list