Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails

nsoffer at redhat.com nsoffer at redhat.com
Tue Mar 4 16:23:55 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: resourceManager: Keep resource state if registerResource fails
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/25284/2/tests/resourceManagerTests.py
File tests/resourceManagerTests.py:

Line 736:             raise
Line 737: 
Line 738:     # Helpers
Line 739: 
Line 740:     def assertAcquireResourceFails(self, namespace, name, locktype):
> perhaps rename to assertAcquireResourceFailsInternally or something like th
The name is little too long for me. If we will have more asserts we can rethink this name.
Line 741:         class Failure(Exception):
Line 742:             pass
Line 743: 
Line 744:         def FakeRequestRef(*a, **kw):


-- 
To view, visit http://gerrit.ovirt.org/25284
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel P. Berrange <berrange at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list