Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails

nsoffer at redhat.com nsoffer at redhat.com
Tue Mar 4 16:19:39 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: resourceManager: Keep resource state if registerResource fails
......................................................................


Patch Set 3:

Changes:
- When checking if resource can be acquired, check both exclusive and shared locks. For checking if resource is not locked, checking exclusive is enough, but checking also shared ensure that we this code path is not broken now. It does not cost anything and make the test code more readable.
- Add new tests checking failure while exclusive lock is held

-- 
To view, visit http://gerrit.ovirt.org/25284
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel P. Berrange <berrange at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list