Change in vdsm[master]: setupNetworks: Fix incorrect mtu overriding when adding mult...

asegurap at redhat.com asegurap at redhat.com
Tue Mar 4 16:19:00 UTC 2014


Antoni Segura Puimedon has uploaded a new change for review.

Change subject: setupNetworks: Fix incorrect mtu overriding when adding multiple networks
......................................................................

setupNetworks: Fix incorrect mtu overriding when adding multiple networks

When configuring several networks over a bond, if the iteration over
the networks to be added made networks with lower MTUs to be added
after those with higher ones, the last mtu, regardless of value would
be set.

This was because the _netinfo object is passed from addNetworks to
addNetworks and the objectivize of the succeeding addNetworks would
not see the higher MTUs set by the preceding addNetworks.

Change-Id: Ia375c2e0e4a1896ab99d734e3203a5ef49570f36
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072411
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
---
M vdsm/configNetwork.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/25343/1

diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py
index ea875f9..2b6162b 100755
--- a/vdsm/configNetwork.py
+++ b/vdsm/configNetwork.py
@@ -644,6 +644,7 @@
             logger.debug("Adding network %r" % network)
             addNetwork(network, configurator=configurator,
                        implicitBonding=True, _netinfo=_netinfo, **d)
+            _netinfo.updateDevices()  # Things like a bond mtu can change
 
         if utils.tobool(options.get('connectivityCheck', True)):
             logger.debug('Checking connectivity...')


-- 
To view, visit http://gerrit.ovirt.org/25343
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia375c2e0e4a1896ab99d734e3203a5ef49570f36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>


More information about the vdsm-patches mailing list