Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults

osvoboda at redhat.com osvoboda at redhat.com
Tue Mar 4 15:37:15 UTC 2014


Ondřej Svoboda has posted comments on this change.

Change subject: netinfo: Retrieve bonding options differing from defaults
......................................................................


Patch Set 13: Verified-1

There are a few functional tests that fail, we are dealing with them, therefore a -1.


For a later iteration we might consider gathering default values  of different bonding modes. E.g. after VDSM sets the miimon to its own default of 150 and, importantly, the mode to 4 (802.3ad), there appear new /sys nodes, which results in BONDING_OPTS reporting them too:

ad_actor_key=0 ad_aggregator=0 ad_num_ports=0 ad_partner_key=0 miimon=150 mode=4

-- 
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list