Change in vdsm[master]: utils: Remove duplicate set non-blocking functions
nsoffer at redhat.com
nsoffer at redhat.com
Mon Jun 30 15:37:55 UTC 2014
Nir Soffer has posted comments on this change.
Change subject: utils: Remove duplicate set non-blocking functions
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/29413/1/vdsm/storage/remoteFileHandler.py
File vdsm/storage/remoteFileHandler.py:
Line 232: env['PYTHONPATH'].split(":")))
Line 233: self.process = CPopen([constants.EXT_PYTHON, __file__,
Line 234: str(hisRead), str(hisWrite)],
Line 235: close_fds=False, env=env)
Line 236:
> the only user of misc.setNonBlocking is called on (myRead, myWrite), which
+1 - even if it was used it is better that the caller does this.
Line 237: self.proxy = CrabRPCProxy(myRead, myWrite)
Line 238:
Line 239: except:
Line 240: os.close(myWrite)
--
To view, visit http://gerrit.ovirt.org/29413
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd242e8b437e485e45127d083c35957ccecf577
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list