Change in vdsm[master]: utils: Remove duplicate set non-blocking functions

danken at redhat.com danken at redhat.com
Mon Jun 30 15:12:49 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: utils: Remove duplicate set non-blocking functions
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/29413/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 1142:     def prependDefer(self, func, *args, **kwargs):
Line 1143:         self._finally.insert(0, (func, args, kwargs))
Line 1144: 
Line 1145: 
Line 1146: def setNonBlocking(fd):
> Please don't.  I prefer names_with_underscores, but a module should have co
Nir, I understand your appeal for consistency, but this patch introduces a new function; new users may pop up in the future.  Every such function postpones the date for modern names to an indefinite future, as I do not see anyone committing himself to an atomic replace of all function names here.
Line 1147:     if hasattr(fd, "fileno"):
Line 1148:         fd = fd.fileno()
Line 1149: 
Line 1150:     fl = fcntl.fcntl(fd, fcntl.F_GETFL)


-- 
To view, visit http://gerrit.ovirt.org/29413
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd242e8b437e485e45127d083c35957ccecf577
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list