Change in vdsm[master]: Live Merge: improve log messages

fromani at redhat.com fromani at redhat.com
Fri Jun 27 14:46:50 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: Live Merge: improve log messages
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

seems a nice improvement.

http://gerrit.ovirt.org/#/c/29310/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 5461:                 ret = None
Line 5462:                 if 'done' not in job:
Line 5463:                     ret = self._dom.blockJobInfo(drive.name, 0)
Line 5464:                     if not ret:
Line 5465:                         self.log.debug("Block Job %s has ended", jobID)
Maybe change to info? no big deal however.
Line 5466:                         job['done'] = True
Line 5467: 
Line 5468:                 entry = {'id': jobID, 'jobType': 'block',
Line 5469:                          'blockJobType': job['blockJobType'],


-- 
To view, visit http://gerrit.ovirt.org/29310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5d22e4c503d5781eb1dc00c6c326146d5bbbbd1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list