Change in vdsm[master]: Live Merge: improve log messages

gpadgett at redhat.com gpadgett at redhat.com
Fri Jun 27 14:35:48 UTC 2014


Greg Padgett has posted comments on this change.

Change subject: Live Merge: improve log messages
......................................................................


Patch Set 1: Verified+1 Code-Review+1

My only reservation here is the job id first appears only at debug level, so if an error occurs and debug logging isn't enabled there is little host-side information to determine the specifics of what the job with that id was doing.  However, it is cleaner and with a little investigating you can figure out what was going on.

-- 
To view, visit http://gerrit.ovirt.org/29310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5d22e4c503d5781eb1dc00c6c326146d5bbbbd1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list