Change in vdsm[master]: vdsm: fixing optional parameters
danken at redhat.com
danken at redhat.com
Thu Jun 19 07:57:14 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: fixing optional parameters
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/28857/2//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2014-06-17 16:07:32 +0200
Line 4: Commit: pkliczewski <piotr.kliczewski at gmail.com>
Line 5: CommitDate: 2014-06-18 16:00:51 +0200
Line 6:
Line 7: vdsm: fixing optional parameters
"vdsm" is an information-free prefix. "utils:" would make more sense.
Line 8:
Line 9: Adding names for optional parameters so we do not need to
Line 10: depend on ordering.
Line 11:
http://gerrit.ovirt.org/#/c/28857/2/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 280: def __init__(self, requestHandler=IPXMLRPCRequestHandler,
Line 281: logRequests=True, allow_none=False, encoding=None,
Line 282: bind_and_activate=False):
Line 283: ConnectedSimpleXmlRPCServer.__init__(self, requestHandler,
Line 284: logRequests, allow_none, encoding)
why not here, too?
Line 285:
Line 286:
Line 287: # Threaded version of SimpleXMLRPCServer
Line 288: class SimpleThreadedXMLRPCServer(SocketServer.ThreadingMixIn,
--
To view, visit http://gerrit.ovirt.org/28857
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2649a7d3a8a1e98268356833ad9bc6a4eaed1715
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list