Change in vdsm[master]: vdsm: sslTests updated to use sslutils

danken at redhat.com danken at redhat.com
Thu Jun 19 07:55:20 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: sslTests updated to use sslutils
......................................................................


Patch Set 3: Code-Review-1

Could you explain why this is favorable? Testing the higher-level SecureXMLRPCServer makes sense; it has a slightly wider coverage.

(But I would like to see the broken commandline test in SecureXMLRPCServer.py fixed or removed)

-- 
To view, visit http://gerrit.ovirt.org/28807
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I630acc8f2e29764c35a77f45ab6f08eef46433ad
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list