Change in vdsm[master]: configurator.py: fix _removeFile to do as described in it's ...
mtayer at redhat.com
mtayer at redhat.com
Tue Jun 17 08:44:21 UTC 2014
mooli tayer has posted comments on this change.
Change subject: configurator.py: fix _removeFile to do as described in it's doc string.
......................................................................
Patch Set 3:
(1 comment)
Douglas: Why rebase in reverse order than now?
These are two separate issues.
http://gerrit.ovirt.org/#/c/28782/3/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 322: try:
Line 323: os.unlink(content['path'])
Line 324:
Line 325: if utils.isOvirtNode():
Line 326: NodeCfg().unpersist(content['path'])
> Does it raise OSError?
Right, will do. thanks.
Line 327: except OSError as e:
Line 328: if e.errno != errno.ENOENT:
Line 329: raise InvalidRun("Removing file: %s failed", content['path'])
Line 330:
--
To view, visit http://gerrit.ovirt.org/28782
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0436832ae63891c097038ef2b76606c30c40328a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list