Change in vdsm[master]: configurator.py: fix _removeFile to do as described in it's ...

nsoffer at redhat.com nsoffer at redhat.com
Tue Jun 17 07:45:39 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: configurator.py: fix _removeFile to do as described in it's doc string.
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/28782/3/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 322:         try:
Line 323:             os.unlink(content['path'])
Line 324: 
Line 325:             if utils.isOvirtNode():
Line 326:                 NodeCfg().unpersist(content['path'])
Does it raise OSError?

If NodeCfg().unpersist(content['path']) has its own error handling, and does not need the ENOENT check, please move it outside the try block.
Line 327:         except OSError as e:
Line 328:             if e.errno != errno.ENOENT:
Line 329:                 raise InvalidRun("Removing file: %s failed", content['path'])
Line 330: 


-- 
To view, visit http://gerrit.ovirt.org/28782
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0436832ae63891c097038ef2b76606c30c40328a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list