Change in vdsm[master]: vdsClient: alternative ways to provide password

dkuznets at redhat.com dkuznets at redhat.com
Tue Jun 17 05:47:42 UTC 2014


Dima Kuznetsov has posted comments on this change.

Change subject: vdsClient: alternative ways to provide password
......................................................................


Patch Set 16:

Hey Alon,

Currently params= argument cannot contain spaces and is limited to being the 5th argument, now, if we want to add another optional argument without forcing the user to supply any other optional arguments, positions of other optional arguments cannot remain fixed.

This is ok though because we can guess what to do with each argument:
* if it starts with auth= it is the authentication argument.
* if it is 'disconnect', 'keep', or 'fail', it is the action argument.
* otherwise we can assume it is the params= argument, because thats the only option left.

-- 
To view, visit http://gerrit.ovirt.org/24733
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list