Change in vdsm[master]: Adding removeConf to sanlock module
dougsland at redhat.com
dougsland at redhat.com
Tue Jun 17 03:34:48 UTC 2014
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Adding removeConf to sanlock module
......................................................................
Patch Set 6: Code-Review-1
(2 comments)
Yaniv, have you tested in ovirtNode? Not sure if it will work in ovirt-node, please see my comments.
http://gerrit.ovirt.org/#/c/26055/6/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 614: ','.join(self.SANLOCK_GROUPS),
Line 615: SANLOCK_USER
Line 616: ),
Line 617: raw=True,
Line 618: )
if isOvirt: persist /etc/group ?
Line 619: sys.stdout.write(out)
Line 620: sys.stderr.write(err)
Line 621: if rc != 0:
Line 622: raise RuntimeError("Failed to perform sanlock config.")
Line 639: raw=True,
Line 640: )
Line 641: sys.stdout.write(out)
Line 642: sys.stderr.write(err)
Line 643:
What about include: if isOvirt: persist /etc/group
Line 644: if rc != 0:
Line 645: raise InvalidRun("Failed to remove sanlock groups.")
Line 646:
Line 647: def isconfigured(self):
--
To view, visit http://gerrit.ovirt.org/26055
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I668552fa037414e9a6aee5b049d61749268f85d0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list