Change in vdsm[master]: Adding "updateVmPolicy" api
danken at redhat.com
danken at redhat.com
Mon Jun 16 14:28:50 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: Adding "updateVmPolicy" api
......................................................................
Patch Set 50: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/27272/50/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3668: #
Line 3669: # Process provided properties, remove property after it is processed
Line 3670:
Line 3671: if 'vcpuLimit' in params:
Line 3672: metadataType = libvirt.VIR_DOMAIN_METADATA_ELEMENT
the assignment to this one-time-used variable is only confusing, in my opinion.
Line 3673:
Line 3674: try:
Line 3675: self._dom.setMetadata(metadataType, '<qos><vcpulimit>' +
Line 3676: params['vcpuLimit'] +
--
To view, visit http://gerrit.ovirt.org/27272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe
Gerrit-PatchSet: 50
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <kobi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list