Change in vdsm[master]: domainMonitor: Stop domain monitors concurrently

Federico Simoncelli fsimonce at redhat.com
Mon Jun 16 14:27:26 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: domainMonitor: Stop domain monitors concurrently
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/27573/3/vdsm/storage/domainMonitor.py
File vdsm/storage/domainMonitor.py:

Line 116:         except KeyError:
Line 117:             self.log.warning("No monitor for %s", sdUUID)
Line 118:         else:
Line 119:             if wait:
Line 120:                 self.waitForMonitor(sdUUID)
At first sight it seems to me that if we don't waitForMonitor we'll get a stale key in _domains (no one removes the entry).
Line 121: 
Line 122:     def waitForMonitor(self, sdUUID):
Line 123:         # If you are stopping multiple monitors, you want to invoke
Line 124:         # stopMonitoring with wait=False, and wait on them after all of the


-- 
To view, visit http://gerrit.ovirt.org/27573
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12f137f1ed055316767e1a9384d8982720bc564
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list