Change in vdsm[master]: utils: Correct and faster list2cmdline

Federico Simoncelli fsimonce at redhat.com
Mon Jun 16 06:37:21 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: utils: Correct and faster list2cmdline
......................................................................


Patch Set 7: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/27548/7/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 731: 
Line 732:     if not printable:
Line 733:         printable = command
Line 734: 
Line 735:     execCmdLogger.debug("%s (cwd %s)", _list2cmdline(printable), cwd)
> Ok, I',ll handle this in a following patch - this is a general issue and we
Yes it seems something that belongs to another patch.
Line 736: 
Line 737:     p = CPopen(command, close_fds=True, cwd=cwd, env=env,
Line 738:                deathSignal=deathSignal, childUmask=childUmask)
Line 739:     if not sync:


-- 
To view, visit http://gerrit.ovirt.org/27548
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfc7819c126fe51cc068cc6f9f85b1002878385b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list