Change in vdsm[master]: clarify why scsiKey parameter is not passed on

amureini at redhat.com amureini at redhat.com
Mon Jun 16 06:25:40 UTC 2014


Allon Mureinik has posted comments on this change.

Change subject: clarify why scsiKey parameter is not passed on
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/28560/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: clarify why scsiKey parameter is not passed on
Line 8: 
Line 9: In this patch I add comments to make plain that the scsiKey parameter is
Line 10: a legacy from older code. This will hopefully save time for the next guy
> I suggest to use the word person instead of guy :-)
+1 on using gender neutral terms. 
"person"  is definitely better than "guy", but how about using the more meaningful "developer"
Line 11: who goes on this wild goose chase through the code.
Line 12: 
Line 13: Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2


-- 
To view, visit http://gerrit.ovirt.org/28560
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list