Change in vdsm[master]: jsonrpc: xmlrpc protocol detection

danken at redhat.com danken at redhat.com
Wed Jun 11 11:30:05 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: jsonrpc: xmlrpc protocol detection
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/28507/6/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 254: 
Line 255: class ConnectedSimpleXmlRPCServer(ConnectedTCPServer,
Line 256:                                   SimpleXMLRPCDispatcher):
Line 257:     """
Line 258:     Code based on Python 2.7's SimpleXMLRPCServer.SimpleXMLRPCServer.__init__
now that you've dropped the close-on-exec code, comment is not so important... but never mind.
Line 259:     """
Line 260: 
Line 261:     def __init__(self, requestHandler, logRequests=True, allow_none=False,
Line 262:                  encoding=None):


-- 
To view, visit http://gerrit.ovirt.org/28507
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72819cc0ab5bde0150456263ab7dd1a5e99abfeb
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list