Change in vdsm[master]: netinfo: Report current system values for bonding options

danken at redhat.com danken at redhat.com
Wed Jun 11 11:24:29 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Report current system values for bonding options
......................................................................


Patch Set 51: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/24456/51/vdsm/network/models.py
File vdsm/network/models.py:

Line 239
Line 240
Line 241
Line 242
Line 243
Sorry for noticing this only now, but this is a change of functionality. Until now, we copied former options from existring ifcfg file. Now we ignore them. This change is fine, but it deserves its own patch, with a clear warning in its commit message


-- 
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 51
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list