Change in vdsm[master]: LiveMerge: Add merge verb and related machinery

Federico Simoncelli fsimonce at redhat.com
Wed Jun 11 08:59:14 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: LiveMerge: Add merge verb and related machinery
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

http://gerrit.ovirt.org/#/c/26635/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4923:         if res['info']['voltype'] == 'SHARED':
Line 4924:             self.log.error("merge: Refusing to merge into a shared volume")
Line 4925:             return errCode['mergeErr']
Line 4926: 
Line 4927:         ret = self._findAndsetDiskBlockJob(drive['path'], jobUUID, base, top)
We should probably use a specific exception here.
Line 4928:         if ret is False:
Line 4929:             self.log.error("Another block job is already active on this disk")
Line 4930:             return errCode['mergeErr']
Line 4931: 


Line 4933:             ret = self._dom.blockCommit(drive.path, base, top, bandwidth, 0)
Line 4934:             if ret != 0:
Line 4935:                 raise RuntimeError("blockCommit operation failed rc:%i", ret)
Line 4936:         except Exception:
Line 4937:             self.log.error("Live merge failed for '%s'", drive.path,
This is enough:

 self.log.exception("Live merge failed for '%s'", drive.path)
Line 4938:                            exc_info=True)
Line 4939:             self._findAndsetDiskBlockJob(drive['path'], None)
Line 4940:             return errCode['mergeErr']
Line 4941: 


-- 
To view, visit http://gerrit.ovirt.org/26635
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I077e1bdf0130ebdc218135ca717a6a810bbab12c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list