Change in vdsm[master]: Adding "updateVmPolicy" api

kobi at redhat.com kobi at redhat.com
Wed Jun 11 08:42:54 UTC 2014


Kobi Ianko has posted comments on this change.

Change subject: Adding "updateVmPolicy" api
......................................................................


Patch Set 27:

(1 comment)

http://gerrit.ovirt.org/#/c/27272/27/client/vdsClient.py
File client/vdsClient.py:

Line 258:     def setNumberOfCpus(self, args):
Line 259:         return self.ExecAndExit(self.s.setNumberOfCpus(args[0], args[1]))
Line 260: 
Line 261:     def updateVmPolicy(self, args):
Line 262:         params = {'vmId': args[0], 'vcpuLimit': args[1]}
> shouldn't** be kept
I don't think that's user friendly to ask the user to type in a python dict
Line 263:         return self.ExecAndExit(self.s.updateVmPolicy(params))
Line 264: 
Line 265:     def do_changeCD(self, args):
Line 266:         vmId = args[0]


-- 
To view, visit http://gerrit.ovirt.org/27272
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <kobi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list