Change in vdsm[master]: Implement rest of os and os.path functionality

ykaplan at redhat.com ykaplan at redhat.com
Thu Jun 5 08:01:04 UTC 2014


Yeela Kaplan has posted comments on this change.

Change subject: Implement rest of os and os.path functionality
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.ovirt.org/#/c/27482/10/vdsm/storage/outOfProcess.py
File vdsm/storage/outOfProcess.py:

Line 184:             self.glob = _IOProcessGlob(ioproc)
Line 185:             self.fileUtils.validateAccess = \
Line 186:                 _IOProcessFileUtils(ioproc).validateAccess
Line 187:             self.fileUtils.pathExists = \
Line 188:                 _IOProcessFileUtils(ioproc).pathExists
> What about fsyncPath?
Same here, Indeed fsyncPath is missing, but this is fixed in following patches.

So would just be a time consuming rebase.

Up to you...
Line 189:             self.os.chmod = _IOProcessOs(ioproc).chmod
Line 190:             self.os.statvfs = _IOProcessOs(ioproc).statvfs
Line 191:             self.os.rename = _IOProcessOs(ioproc).rename
Line 192:             self.os.unlink = _IOProcessOs(ioproc).unlink


-- 
To view, visit http://gerrit.ovirt.org/27482
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4476982ba0125f8b1d8466f5f5809a0e9464cf5
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list