Change in vdsm[master]: oop: Add an option to configure oop implementation

ykaplan at redhat.com ykaplan at redhat.com
Thu Jun 5 07:57:45 UTC 2014


Yeela Kaplan has posted comments on this change.

Change subject: oop: Add an option to configure oop implementation
......................................................................


Patch Set 15:

(1 comment)

http://gerrit.ovirt.org/#/c/26576/15/vdsm/storage/outOfProcess.py
File vdsm/storage/outOfProcess.py:

Line 68: class _ModuleWrapper(types.ModuleType):
Line 69:     def __init__(self, modName, procPool, ioproc, timeout, subModNames=()):
Line 70:         self._modName = modName
Line 71:         self._procPool = procPool
Line 72:         self._iop = ioproc
> This is not used (not even in the following patches).
True. You are correct. But it is also being removed in the following patches. 

To fix this would just be wasting time on an unnecessary rebase. cause as it is this patch won't get in without the others.


So I'd appreciate if we could skip this fix, unless you feel it's really important.
Line 73:         self._timeout = timeout
Line 74: 
Line 75:         for subModName in subModNames:
Line 76:             subSubModNames = []


-- 
To view, visit http://gerrit.ovirt.org/26576
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd756afd43d23631dc7ed4bac64bec9a81b358b4
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list