Change in vdsm[master]: jsonrpc: Vdsm changes

tjeyasin at redhat.com tjeyasin at redhat.com
Tue Jan 28 06:39:12 UTC 2014


Timothy Asir has posted comments on this change.

Change subject: jsonrpc: Vdsm changes
......................................................................


Patch Set 23:

(6 comments)

http://gerrit.ovirt.org/#/c/19497/23/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

Line 51: 
Line 52: 
Line 53: class JsonRpcInvalidRequestError(JsonRpcError):
Line 54:     log = logging.getLogger("JsonRpcInvalidRequestError")
Line 55:     
remove this white space also in line number 160.
Line 56:     def __init__(self, object_name, msg_content):    
Line 57:         self.log.error("Invalid message found " + msg_content)
Line 58:         JsonRpcError.__init__(self, -32600,
Line 59:                               "The JSON sent is not a valid Request object "


Line 52: 
Line 53: class JsonRpcInvalidRequestError(JsonRpcError):
Line 54:     log = logging.getLogger("JsonRpcInvalidRequestError")
Line 55:     
Line 56:     def __init__(self, object_name, msg_content):    
remove this white space at the end of line
Line 57:         self.log.error("Invalid message found " + msg_content)
Line 58:         JsonRpcError.__init__(self, -32600,
Line 59:                               "The JSON sent is not a valid Request object "
Line 60:                               "with " + object_name)


Line 152:     def decode(msg):
Line 153:         obj = json.loads(msg, 'utf-8')
Line 154: 
Line 155:         if "result" not in obj and "error" not in obj:
Line 156:             raise JsonRpcInvalidRequestError("missing result or error info", obj)
line exceeds 80 chars in line numbers 156, 163, 172 &  179.
Line 157: 
Line 158:         result = obj.get('result')
Line 159:         error = JsonRpcError(**obj.get('error'))
Line 160:         


http://gerrit.ovirt.org/#/c/19497/23/vdsm/gluster/apiwrapper.py
File vdsm/gluster/apiwrapper.py:

Line 106:         return self._gluster.volumeStatus(volumeName, brick, statusOption)
Line 107: 
Line 108:     def profileInfo(self, volumeName, nfs=False):
Line 109:         return self._gluster.volumeProfileInfo(volumeName, nfs)
Line 110: 
move this profileInfo under profile related methods.
Line 111:     def list(self, volumeName=None):
Line 112:         return self._gluster.volumesList(volumeName)
Line 113: 
Line 114:     def create(self, volumeName, brickList, replicaCount=0, stripeCount=0,


Line 111:     def list(self, volumeName=None):
Line 112:         return self._gluster.volumesList(volumeName)
Line 113: 
Line 114:     def create(self, volumeName, brickList, replicaCount=0, stripeCount=0,
Line 115:                transportList=[]):
Add force option also and the default value should be set to 'false'.
Line 116:         return self._gluster.volumeCreate(volumeName, brickList, replicaCount,
Line 117:                                           stripeCount, transportList)
Line 118: 
Line 119:     def start(self, volumeName, force=False):


Line 174: 
Line 175:     def replaceBrickStart(self, volumeName, existingBrick, newBrick):
Line 176:         return self._gluster.volumeReplaceBrickStart(volumeName, existingBrick,
Line 177:                                                      newBrick)
Line 178: 
move this replaceBrickStart under replaceBrick related functions.
Line 179:     def rebalanceStatus(self, volumeName):


-- 
To view, visit http://gerrit.ovirt.org/19497
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If828355b7efe28fe6a2e784069425fefd2f3f25c
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list