Change in vdsm[master]: jsonrpc: Vdsm changes
barumuga at redhat.com
barumuga at redhat.com
Tue Jan 28 06:31:34 UTC 2014
Bala.FA has posted comments on this change.
Change subject: jsonrpc: Vdsm changes
......................................................................
Patch Set 23:
(2 comments)
Poitr, could you share some context/design about this patch? Sorry, I might have missed that.
http://gerrit.ovirt.org/#/c/19497/23/lib/yajsonrpc/Makefile.am
File lib/yajsonrpc/Makefile.am:
Line 23: dist_yajsonrpc_PYTHON = \
Line 24: __init__.py \
Line 25: asyncoreReactor.py \
Line 26: protonReactor.py \
Line 27: betterAsyncore.py \
This list needs to sorted alphabetically
Line 28: $(NULL)
http://gerrit.ovirt.org/#/c/19497/23/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 52:
Line 53: class JsonRpcInvalidRequestError(JsonRpcError):
Line 54: log = logging.getLogger("JsonRpcInvalidRequestError")
Line 55:
Line 56: def __init__(self, object_name, msg_content):
Please clear whitespaces
Line 57: self.log.error("Invalid message found " + msg_content)
Line 58: JsonRpcError.__init__(self, -32600,
Line 59: "The JSON sent is not a valid Request object "
Line 60: "with " + object_name)
--
To view, visit http://gerrit.ovirt.org/19497
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If828355b7efe28fe6a2e784069425fefd2f3f25c
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list