Change in vdsm[master]: To allow downgrade of vdsm we need to support vdsm-tool old API

Alon Bar-Lev alonbl at redhat.com
Thu Jan 16 22:08:23 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: To allow downgrade of vdsm we need to support vdsm-tool old API
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/23333/1/vdsm.spec.in
File vdsm.spec.in:

Line 791:     then
Line 792:         if ! %{_bindir}/vdsm-tool configure --module libvirt --force \
Line 793:                 >/dev/null 2>&1; then
Line 794:             # fallback to vdsmd reconfigure api
Line 795:             for f in '/etc/init.d/vdsmd' '/lib/systemd/systemd-vdsmd'; do
I would have done that exactly the opposite :)

but not that important.
Line 796:                 if [ -f "${f}" ]; then
Line 797:                     "${f}" reconfigure >/dev/null 2>&1
Line 798:                 fi
Line 799:             done


Line 793:                 >/dev/null 2>&1; then
Line 794:             # fallback to vdsmd reconfigure api
Line 795:             for f in '/etc/init.d/vdsmd' '/lib/systemd/systemd-vdsmd'; do
Line 796:                 if [ -f "${f}" ]; then
Line 797:                     "${f}" reconfigure >/dev/null 2>&1
force?

|| true - to avoid errors during yum?
Line 798:                 fi
Line 799:             done
Line 800:         fi
Line 801:     fi


-- 
To view, visit http://gerrit.ovirt.org/23333
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bd7f9048acc4f53f3da66e21d5ad2c5caf2a5ad
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list