Change in vdsm[master]: To allow downgrade of vdsm we need to support vdsm-tool old API
danken at redhat.com
danken at redhat.com
Thu Jan 16 18:40:02 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: To allow downgrade of vdsm we need to support vdsm-tool old API
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/23333/1//COMMIT_MSG
Commit Message:
Line 8:
Line 9: During upgrading or downgrading vdsm version we perform reconfigure
Line 10: process. This process has been changed between 3.3 to 3.4. This patch
Line 11: tries the current version implementation of reconfigure, and if it fails
Line 12: it will fallback to vdsmd reconfigure verb, which exists and all
and all -> in all
Line 13: previous versions of vdsm.
Line 14:
Line 15: This workaround need to be removed in vdsm 3.5.
Line 16:
http://gerrit.ovirt.org/#/c/23333/1/vdsm.spec.in
File vdsm.spec.in:
Line 790: if ! %{_bindir}/vdsm-tool is-configured --module libvirt >/dev/null 2>&1;
Line 791: then
Line 792: if ! %{_bindir}/vdsm-tool configure --module libvirt --force \
Line 793: >/dev/null 2>&1; then
Line 794: # fallback to vdsmd reconfigure api
I'd prefer to see a comment here saying "remove when downgrade to 3.3 is no longer supported".
Line 795: for f in '/etc/init.d/vdsmd' '/lib/systemd/systemd-vdsmd'; do
Line 796: if [ -f "${f}" ]; then
Line 797: "${f}" reconfigure >/dev/null 2>&1
Line 798: fi
--
To view, visit http://gerrit.ovirt.org/23333
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bd7f9048acc4f53f3da66e21d5ad2c5caf2a5ad
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list