Change in vdsm[master]: storageTests: Extract storage types and versions to an envir...

nsoffer at redhat.com nsoffer at redhat.com
Thu Jan 16 07:19:33 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: storageTests: Extract storage types and versions to an environment variable
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

Nice!

http://gerrit.ovirt.org/#/c/23259/3//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-01-14 19:29:08 +0200
Line 4: Commit:     Vered Volansky <vvolansk at redhat.com>
Line 5: CommitDate: 2014-01-14 19:50:53 +0200
Line 6: 
Line 7: storageTests: Extract storage types and versions to an environment variable
A better title would be: Configure via environment variables
Line 8: 
Line 9: These are used as permutations for the test. We want to automate the
Line 10: test and call it with whatever storage type(s) and metadata
Line 11: version(s).


http://gerrit.ovirt.org/#/c/23259/3/tests/functional/storageTests.py
File tests/functional/storageTests.py:

Line 58:                         )
Line 59: _exportfs = CommandPath("exportfs", "/usr/sbin/exportfs")
Line 60: 
Line 61: DEFAULT_STORAGE_TYPES = ('localfs', 'iscsi', 'glusterfs', 'nfs')
Line 62: STORAGE_TYPES = tuple(os.environ.get('VDSM_STORAGE_TEST_TYPES', '').split()) \
> I like the idea, as I did not find a way to exclude test cases based on per
Please rename both environ variables:

 VDSM_TEST_STORAGE_TYPES
 VDSM_TEST_STORAGE_VERSIONS

And the module constants:

 DEFAULT_TYPES
 TYPES

Since this is the storage module,  STORAGE_ prefix is redundant, leading to long lines then needed.
Line 63:     or DEFAULT_STORAGE_TYPES
Line 64: 
Line 65: DEFAULT_VERSIONS = (0, 3)
Line 66: VERSIONS = tuple(os.environ.get('VDSM_METADATA_TEST_VERSION', '').split()) \


-- 
To view, visit http://gerrit.ovirt.org/23259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84f1ee57e43d921ae38afaabddecca9f38dd2687
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list