Change in vdsm[master]: storageTests: Extract storage types and versions to an envir...
danken at redhat.com
danken at redhat.com
Wed Jan 15 23:16:54 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: storageTests: Extract storage types and versions to an environment variable
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/23259/3/tests/functional/storageTests.py
File tests/functional/storageTests.py:
Line 58: )
Line 59: _exportfs = CommandPath("exportfs", "/usr/sbin/exportfs")
Line 60:
Line 61: DEFAULT_STORAGE_TYPES = ('localfs', 'iscsi', 'glusterfs', 'nfs')
Line 62: STORAGE_TYPES = tuple(os.environ.get('VDSM_STORAGE_TEST_TYPES', '').split()) \
I like the idea, as I did not find a way to exclude test cases based on permutations.
Would you rename the environment variable to
VDSM_TEST_STORAGE_TYPES
so the idea could be easier to extend to
VDSM_TEST_VIRT_bla
?
Line 63: or DEFAULT_STORAGE_TYPES
Line 64:
Line 65: DEFAULT_VERSIONS = (0, 3)
Line 66: VERSIONS = tuple(os.environ.get('VDSM_METADATA_TEST_VERSION', '').split()) \
--
To view, visit http://gerrit.ovirt.org/23259
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I84f1ee57e43d921ae38afaabddecca9f38dd2687
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list