Change in vdsm[ovirt-3.3]: BindingXMLRPC bugfix: Return lastClientIface for current con...

ybronhei at redhat.com ybronhei at redhat.com
Tue Jan 7 11:28:38 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: BindingXMLRPC bugfix: Return lastClientIface for current connection
......................................................................


BindingXMLRPC bugfix: Return lastClientIface for current connection

The patch does three things:
1) Fixes a bug where lastClientIface was for the previous
   connection, and not the current one. The method to retrieve
   the last client was through a log_request LoggingMixIn
   which is invoked at the end of a response, not at the beginning.
   The patch removes the usage of that MixIn, and instead uses
   values that are updated at the beginning of the connection
2) Simplifies the 'LoggingMixin' out of the picture as its no
   longer needed
3) Remove unused variables:
     server.lastClientTime
     server.lastClient
     server.lastServerIP

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1048596
Change-Id: I36e48cc07a27f44a2b413f0e9159110404f1b0ca
Signed-off-by: Assaf Muller <amuller at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22837
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22967
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Tested-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/BindingXMLRPC.py
1 file changed, 15 insertions(+), 25 deletions(-)

Approvals:
  Yaniv Bronhaim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22967
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I36e48cc07a27f44a2b413f0e9159110404f1b0ca
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list