Change in vdsm[master]: bootstrap: Return recovery error until hsm is ready

ybronhei at redhat.com ybronhei at redhat.com
Sun Jan 5 15:59:38 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: bootstrap: Return recovery error until hsm is ready
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

-1 just to understand the True default reason

....................................................
File vdsm/storage/dispatcher.py
Line 99:         self.log.info("Starting StorageDispatcher...")
Line 100: 
Line 101:     @property
Line 102:     def ready(self):
Line 103:         return getattr(self._obj, 'ready', True)
why default True.. I'd put False. if ready is not exist, how can you assume that HSM is ready ??
Line 104: 
Line 105:     def _exposeFunctions(self, obj):
Line 106:         for funcName in dir(obj):
Line 107:             funcObj = getattr(obj, funcName)


-- 
To view, visit http://gerrit.ovirt.org/21530
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list