Change in vdsm[master]: sp: improve masterMigrate safety

abaron at redhat.com abaron at redhat.com
Wed Jan 1 08:25:32 UTC 2014


Ayal Baron has posted comments on this change.

Change subject: sp: improve masterMigrate safety
......................................................................


Patch Set 3:

(1 comment)

....................................................
File vdsm/storage/sp.py
Line 869:             newmsd.changeRole(sd.MASTER_DOMAIN)
Line 870:             self.switchMasterDomain(curmsd, newmsd, masterVersion)
Line 871:         except Exception:
Line 872:             self.log.exception('migration to new master failed')
Line 873:             newmsd.unmountMaster()
would unmountMaster fail or succeed if already unmounted?
if this throws an exception we will loose the original one.
maybe try..except..else ?
Line 874:             newmsd.releaseClusterLock()
Line 875:             raise
Line 876: 
Line 877:         # From this point on we have a new master and should not fail


-- 
To view, visit http://gerrit.ovirt.org/22419
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I155b36d41df43230f99ba610699bba05bee3f0c0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list