Change in vdsm[master]: sp: split metadata transaction in createMaster

abaron at redhat.com abaron at redhat.com
Wed Jan 1 07:56:51 UTC 2014


Ayal Baron has posted comments on this change.

Change subject: sp: split metadata transaction in createMaster
......................................................................


Patch Set 4:

(1 comment)

See patch set 4

....................................................
File vdsm/storage/sp.py
Line 695:         self.stopMonitoringDomains()
Line 696:         return True
Line 697: 
Line 698:     @unsecured
Line 699:     def initMasterDomain(self, poolName, domain, masterVersion):
but it's not the master metadata, it's the pool metadata.
that is the differentiation between initMaster and this.
Since it is in the context of the pool then it could be just initMetadata
Line 700:         self._getPoolMD(domain).update({
Line 701:             PMDK_SPM_ID: SPM_ID_FREE,
Line 702:             PMDK_LVER: LVER_INVALID,
Line 703:             PMDK_MASTER_VER: masterVersion,


-- 
To view, visit http://gerrit.ovirt.org/22418
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b22af92b1f9a481be9af844b1acc47ae513d078
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list