Change in vdsm[master]: netinfo: Determine bootproto from dhclient's lease files

danken at redhat.com danken at redhat.com
Sat Feb 1 08:14:38 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Determine bootproto from dhclient's lease files
......................................................................


Patch Set 16: Code-Review-1

(3 comments)

few minor comments remain

http://gerrit.ovirt.org/#/c/23098/16//COMMIT_MSG
Commit Message:

Line 9: Lease files are never deleted, just replaced so they do not
Line 10: become too long. For DHCPv4 checking for an expiration time
Line 11: of a lease was added, DHCPv6 leases use different flags.
Line 12: 
Line 13: TODO:
isn't that already done, by virtue of the path list in netinfo.py?
Line 14: For non-NetworkManager setups, a path to lease files must
Line 15: be configurable for (downstream and) users.
Line 16: 
Line 17: Change-Id: I5fbc48a0adf5f40120a72ec2c4cc2fc80b7226b8


http://gerrit.ovirt.org/#/c/23098/16/tests/functional/firewall.py
File tests/functional/firewall.py:

Line 1: # Copyright 2013-2014 Red Hat, Inc.
please avoid moving lines needlessly. I actually like the leading comment line.
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by
Line 5: # the Free Software Foundation; either version 2 of the License, or


http://gerrit.ovirt.org/#/c/23098/16/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 1699: 
Line 1700:                 with dnsmasqDhcp(server):
Line 1701: 
Line 1702:                     with namedTemporaryDir(dir='/var/lib/dhclient') as tmpDir:
Line 1703:                         leaseFile = os.path.join(tmpDir + 'test.lease')
use coma, not plus.
Line 1704:                         pidFile = os.path.join(tmpDir, 'test.pid')
Line 1705: 
Line 1706:                         dhcp.runDhclient(client, leaseFile, pidFile)
Line 1707:                         dhcp4 = getDhclientIfaces([leaseFile])


-- 
To view, visit http://gerrit.ovirt.org/23098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5fbc48a0adf5f40120a72ec2c4cc2fc80b7226b8
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list