Change in vdsm[master]: sp: Nest try-finally for temporary secure change

danken at redhat.com danken at redhat.com
Sat Feb 1 07:57:54 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: sp: Nest try-finally for temporary secure change
......................................................................


Patch Set 1: Code-Review+1

We really miss context manager semantics around _acquireTemporaryClusterLock and setSecure.

-- 
To view, visit http://gerrit.ovirt.org/23955
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9054063db0eeacd156a8e586681496515f80e2b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list