Change in vdsm[master]: multipath configurator: reload only if service is active

ykaplan at redhat.com ykaplan at redhat.com
Mon Dec 29 12:34:14 UTC 2014


Yeela Kaplan has posted comments on this change.

Change subject: multipath configurator: reload only if service is active
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/36387/1/lib/vdsm/tool/configurators/multipath.py
File lib/vdsm/tool/configurators/multipath.py:

Line 146
Line 147
Line 148
Line 149
Line 150
> so the code worked properly but in el6 we didn't warn anything.. afaiu we w
before:
1)reload
2)if status is active and fail: raise vdsm intentional exception
3)if status is inactive on el7: exception raised by service
after:
1)check status
2)reload only if active -> avoids reload and exception if inactive for el7
3)check reload rc -> raise exception if failed (service is active)


-- 
To view, visit http://gerrit.ovirt.org/36387
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1e8eceaaa486f05b1ea4f1733df669b2a44682a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list