Change in vdsm[master]: multipath configurator: reload only if service is active

ybronhei at redhat.com ybronhei at redhat.com
Fri Dec 26 14:51:51 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: multipath configurator: reload only if service is active
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/36387/1/lib/vdsm/tool/configurators/multipath.py
File lib/vdsm/tool/configurators/multipath.py:

Line 146
Line 147
Line 148
Line 149
Line 150
> In el7 reload service when the service is inactive returns code of 1, 
so the code worked properly but in el6 we didn't warn anything.. afaiu we wanted to explode if reload fails and status up? your code will serve it the same way, just you avoid calling reload if the status is not up.. how does it fix the problem? why reload keep failing?


-- 
To view, visit http://gerrit.ovirt.org/36387
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1e8eceaaa486f05b1ea4f1733df669b2a44682a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list