Change in vdsm[master]: hsm: prepareForShutdown - operations order

laravot at redhat.com laravot at redhat.com
Mon Dec 15 13:21:08 UTC 2014


Liron Aravot has posted comments on this change.

Change subject: hsm: prepareForShutdown - operations order
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/36162/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 3432
Line 3433
Line 3434
Line 3435
Line 3436
> I think that it will be more correct to move 
i agree, as of today self.taskMng.prepareForShutdown() already access the shared storage after releaseLocks - but it doesn't access the tasks dir (which it will after this change).
Moving self.taskMng.prepareForShutdown() to be before  self.__releaseLocks() may be trickier in terms of verification imo - but let's here other opinions on that.


-- 
To view, visit http://gerrit.ovirt.org/36162
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9edd84317b08a17db80e265053edaf69582c2a51
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list