Change in vdsm[master]: Using with_rhev flag in spec to configure rhev changes if re...

danken at redhat.com danken at redhat.com
Mon Dec 15 10:49:42 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Using with_rhev flag in spec to configure rhev changes if required
......................................................................


Patch Set 9: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/35722/9/vdsm.spec.in
File vdsm.spec.in:

Line 180: Requires: libvirt >= 0.10.2-29.el6_5.4
Line 181: %else
Line 182: Requires: libvirt >= 1.1.1
Line 183: %if 0%{?rhev_build}
Line 184: Requires: libvirt >= 0.10.2-18.el6_4.4
seems like an old piece of lint. not need to perpetuate.
Line 185: %endif
Line 186: %endif
Line 187: %endif
Line 188: Requires: libvirt-python, libvirt-lock-sanlock, libvirt-client


Line 190: # iscsi-intiator versions
Line 191: %if 0%{?rhel}
Line 192: %if 0%{?rhel} >= 7
Line 193: Requires: iscsi-initiator-utils
Line 194: %if 0%{?rhev_build}
seems like an old piece of lint. not need to perpetuate.
Line 195: Requires: iscsi-initiator-utils >= 6.2.0.873-3
Line 196: %endif
Line 197: %else
Line 198: Requires: iscsi-initiator-utils >= 6.2.0.872-15


-- 
To view, visit http://gerrit.ovirt.org/35722
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30b554e5614bdda2b02538538b5e6514ae94eaf5
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list