Change in vdsm[master]: teach delNetworks to remove a network entity under a bridge

ibarkan at redhat.com ibarkan at redhat.com
Sun Dec 14 13:41:55 UTC 2014


Ido Barkan has posted comments on this change.

Change subject: teach delNetworks to remove a network entity under a bridge
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.ovirt.org/#/c/35921/8/vdsm/network/api.py
File vdsm/network/api.py:

Line 407:                                  network)
Line 408: 
Line 409: 
Line 410: def _delete_bridge_interface(bridge, interface):
Line 411:     logging.info('Deleting interface %s from bridge %s' % (interface, bridge))
fix logging method
Line 412:     rc, out, err = utils.execCmd(
Line 413:         [constants.EXT_BRCTL, 'delif', bridge, interface])
Line 414:     if rc != 0:
Line 415:         raise Exception("could not disconnect interface from bridge. "


-- 
To view, visit http://gerrit.ovirt.org/35921
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6bb891f23ef4550f90c6c7b057aef6302cf435c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list